Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: compress responses in exec_gmp_get with Brotli #158

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Dec 5, 2023

What

In exec_gmp_get, compress responses with Brotli.

This feature is only used if libbrotli is found at build time.

Why

Speeds up data transfer by reducing size of transfer.

Results in smaller sizes than deflate. For example one cmd=edit_config_family request of 1.52MB:

br  73.04kB
de 107.38kB

References

Recent PR for deflate: /pull/143
Brotli encoding C man page: https://man.archlinux.org/man/core/brotli/encode.h.3.en

Copy link

github-actions bot commented Dec 5, 2023

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@mattmundell mattmundell marked this pull request as ready for review December 19, 2023 13:18
@mattmundell mattmundell requested a review from a team as a code owner December 19, 2023 13:18
@timopollmeier timopollmeier merged commit 74624ba into greenbone:main Jan 9, 2024
9 checks passed
@mattmundell mattmundell deleted the brotli branch January 9, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants